Forbid using '..' in paths passed to PathTree #23862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we want the paths to be interpreted in a way that's as similar to ClassLoader#getResource as possible. With the previous behavior, if I pass foo/bar/.. to DirectoryPathTree, it will automatically be resolved to foo/. So in a build step for example, we might end up accepting the path as valid. Later at runtime, we might pass the same string (foo/bar/..) to ClassLoader#getRessource. And then it will fail, because .. has no special meaning for ClassLoader#getResource... See quarkusio#23692 (comment)
For consistency with DirectoryPathTree
quarkus-bot
bot
added
the
area/devtools
aloubyansky
approved these changes
Feb 22, 2022
|
Thanks @yrodiere |
yrodiere
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aloubyansky as you requested here.
If you meant to do this for
DirectoryPathTreeonly, we can drop the second commit.