Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect quarkus.container-image.push=true in container-image-docker #23861

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 22, 2022

This same thing is already properly done in container-image-jib

Fixes: #23836

This same thing is already properly done in container-image-jib

Fixes: quarkusio#23826
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 95cc838 into quarkusio:main Feb 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 22, 2022
@geoand geoand deleted the #23836 branch February 22, 2022 13:07
@michalszynkiewicz
Copy link
Member

@geoand I think you closed my draft PR by accident in this :D

@geoand
Copy link
Contributor Author

geoand commented Feb 22, 2022

Ouch :) Sorry!

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Feb 28, 2022
geoand added a commit to geoand/quarkus that referenced this pull request Mar 8, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Mar 8, 2022
…or native build

Follows up on: quarkusio#23861

(cherry picked from commit 9e34a8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native docker container image is not created/pushed
4 participants