Fix reflection registration issue with Jackson's @JsonSerialize & @JsonDeserialize #17049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onDeserialize This is a follow up to PR quarkusio#12387. It registers the rest of the “using” options (`keyUsing`, `contentUsing`, `nullsUsing`) for both `@JsonSerialize` and `@JsonDeserialize`
geoand
approved these changes
May 6, 2021
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
gsmet
reviewed
May 7, 2021
| // the Deserializers are constructed internally by Jackson using a no-args constructor | ||
| reflectiveClass | ||
| .produce(new ReflectiveClassBuildItem(false, false, contentUsingValue.asClass().name().toString())); | ||
| } |
There was a problem hiding this comment.
Don't we need to also consider all the others (converters, as...)? Not sure about as but the 2 converter properties look like something we should take into account.
There was a problem hiding this comment.
I was wondering the same. I can make another PR and add them.
| // the Deserializers are constructed internally by Jackson using a no-args constructor | ||
| reflectiveClass | ||
| .produce(new ReflectiveClassBuildItem(false, false, nullsUsingValue.asClass().name().toString())); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #12387.
It registers the rest of the “using” options (
keyUsing,contentUsing,nullsUsing) for both@JsonSerializeand@JsonDeserialize