Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that a JAX-RS client exception does not depend on the server parts #16680

Merged
merged 1 commit into from Apr 21, 2021
Merged

Ensure that a JAX-RS client exception does not depend on the server parts #16680

merged 1 commit into from Apr 21, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 21, 2021 •
edited

This is done because if this exception is thrown from the client when
the server parts have not been installed, then we end up with

java.lang.RuntimeException: Resteasy Reactive server side components are not installed

in the logs

@michalszynkiewicz
Copy link
Member

It seems the resteasy testsuite doesn't like the change. Is MicroProfile Rest Client Reactive TCK fine with this?

@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021 •
edited

I have no idea.

I guess I need to see what the TCK failures are all about.

It could be that I end up changing the PR totally

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 95e6d22

Status Name Step Test failures Logs Raw logs
✖ MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/resteasy-reactive/target/testsuite/tests

✖ com.sun.ts.tests.jaxrs.api.client.invocation.JAXRSClient0088.submitGenericTypeStringThrowsWebApplicationExceptionTest line 472 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.api.client.invocation.JAXRSClient0088.invokeStringThrowsWebApplicationExceptionTest line 157 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.api.client.invocation.JAXRSClient0088.submitInvocationCallbackStringThrowsWebAppExceptionTest line 581 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.api.client.invocation.JAXRSClient0088.invokeGenericTypeStringThrowsWebApplicationExceptionTest line 240 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.api.client.invocation.JAXRSClient0088.submitStringThrowsWebApplicationExceptionTest line 387 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.optionsWithGenericTypeThrowsWebApplicationExceptionTest line 1877 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithClassWithEntityThrowsWebApplicationExceptionTest line 1388 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.putWithClassThrowsWebApplicationExceptionTest line 2457 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.postWithClassThrowsWebApplicationExceptionTest line 2126 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.deleteWithGenericTypeThrowsWebApplicationExceptionTest line 309 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.traceWithGenericTypeThrowsWebApplicationExceptionTest line 2894 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.getWithGenericTypeThrowsWebApplicationExceptionTest line 643 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.optionsWithCallbackThrowsWebApplicationExceptionTest line 1975 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithGenericTypeWithEntityThrowsWebApplicationExceptionTest line 1508 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.postWithCallbackThrowsWebApplicationExceptionTest line 2306 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.deleteWithCallbackStringThrowsWebApplicationExceptionTest line 407 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.getWithCallbackStringThrowsWebApplicationExceptionTest line 740 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithClassThrowsWebApplicationExceptionTest line 1000 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithCallbackThrowsWebApplicationExceptionTest line 1230 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.deleteWithClassThrowsWebApplicationExceptionTest line 214 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.traceWithCallbackThrowsWebApplicationExceptionTest line 2991 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.getWithClassThrowsWebApplicationExceptionTest line 549 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithCallbackWithEntityThrowsWebApplicationExceptionTest line 1631 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.methodWithGenericTypeThrowsWebApplicationExceptionTest line 1114 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.postWithGenericTypeThrowsWebApplicationExceptionTest line 2225 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.putWithCallbackThrowsWebApplicationExceptionTest line 2656 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.optionsWithClassThrowsWebApplicationExceptionTest line 1782 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.putWithGenericTypeThrowsWebApplicationExceptionTest line 2556 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.asyncinvoker.JAXRSClient0118.traceWithClassThrowsWebApplicationExceptionTest line 2800 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.methodWithStringClassThrowsWebApplicationExceptionTest line 706 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.postWithStringClassThrowsWebApplicationExceptionTest line 1458 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.putWithGenericTypeStringThrowsWebApplicationExceptionTest line 1798 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.putWithStringClassThrowsWebApplicationExceptionTest line 1697 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.methodWithGenericTypeStringWithEntityThrowsWebApplicationExceptionTest line 1087 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.methodWithGenericTypeStringThrowsWebApplicationExceptionTest line 814 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.deleteWithGenericTypeStringThrowsWebApplicationExceptionTest line 290 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.deleteWithStringClassThrowsWebApplicationExceptionTest line 194 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.postWithGenericTypeStringThrowsWebApplicationExceptionTest line 1559 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.optionsWithGenericTypeStringThrowsWebApplicationExceptionTest line 1320 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.traceWithStringClassThrowsWebApplicationExceptionTest line 1929 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.getWithStringClassThrowsWebApplicationExceptionTest line 420 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.getWithGenericTypeStringThrowsWebApplicationExceptionTest line 516 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.traceWithGenericTypeStringThrowsWebApplicationExceptionTest line 2025 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.optionsWithStringThrowsWebApplicationExceptionTest line 1224 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.ee.rs.client.syncinvoker.JAXRSClient0120.methodWithStringClassWithEntityThrowsWebApplicationExceptionTest line 969 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.optionsWithGenericTypeThrowsWebApplicationExceptionTest line 1243 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.methodWithClassWithEntityThrowsWebApplicationExceptionTest line 919 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.putWithClassThrowsWebApplicationExceptionTest line 1585 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.postWithClassThrowsWebApplicationExceptionTest line 1368 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.deleteWithGenericTypeThrowsWebApplicationExceptionTest line 284 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.traceWithGenericTypeThrowsWebApplicationExceptionTest line 1879 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.getWithGenericTypeThrowsWebApplicationExceptionTest line 487 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.methodWithGenericTypeWithEntityThrowsWebApplicationExceptionTest line 1033 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.methodWithClassThrowsWebApplicationExceptionTest line 663 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.deleteWithClassThrowsWebApplicationExceptionTest line 198 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.getWithClassThrowsWebApplicationExceptionTest line 402 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.methodWithGenericTypeThrowsWebApplicationExceptionTest line 769 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.postWithGenericTypeThrowsWebApplicationExceptionTest line 1459 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.optionsWithClassThrowsWebApplicationExceptionTest line 1157 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.putWithGenericTypeThrowsWebApplicationExceptionTest line 1676 - More details - Source on GitHub

✖ com.sun.ts.tests.jaxrs.jaxrs21.ee.client.rxinvoker.JAXRSClient0180.traceWithClassThrowsWebApplicationExceptionTest line 1794 - More details - Source on GitHub

@geoand
Ensure that a JAX-RS client exception does not depend on the server p…
082b31e 
…arts

This is done because if this exception is thrown from the client when
the server parts have not been installed, then we end up with

'java.lang.RuntimeException: Resteasy Reactive server side components are not installed'

in the logs
@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021

I pushed an update, it should be OK now

@geoand geoand changed the title Remove WebApplicationException as parent of WebClientApplicationException Ensure that a JAX-RS client exception does not depend on the server parts Apr 21, 2021
@michalszynkiewicz
Copy link
Member

Quarkus CI / MicroProfile TCKs Tests (pull_request) Successful in 4m - this looks suspicious
The log says:

2021-04-21T11:44:51.6326083Z [INFO] Changed Artifacts:
2021-04-21T11:44:51.6326888Z [INFO] 
2021-04-21T11:44:51.6338994Z [INFO] resteasy-reactive-client (but deselected)
2021-04-21T11:44:51.6339805Z [INFO] 
2021-04-21T11:44:51.6412170Z [INFO] gitflow-incremental-builder exiting...

Is this normal?

@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021

I dunno, @famod any idea?

@michalszynkiewicz
Copy link
Member

@geoand found the issue. The PR where I enabled it still awaits review: https://github.com/quarkusio/quarkus/pull/16404/files#diff-1bb1ea5149396c30014fb3ec836334fcf6b84d01ba1a8e7219a7cbc443a54e27R28

@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021

Gotcha thanks.

I ran the TCK locally with this change and everything is OK so I am going to merge it.

@geoand geoand merged commit 6c2f4ae into quarkusio:main Apr 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 21, 2021
@geoand geoand deleted the rr-client-exception branch April 21, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

@michalszynkiewicz michalszynkiewicz Awaiting requested review from michalszynkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.3.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@geoand @michalszynkiewicz @FroMage @gsmet