Don't index invisible muti-release classes #16667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't index classes that are not able to be loaded as the current Java version is too low. Note that if a newer JDK is used to run the resulting application these classes will become visible, however this is less likely to cause problems than the current situation. This is because adding invisible classes to the index can result in bytecode being generated which references these classes, which will cause startup to fail. The alternative of not adding them to the index only means that some annotation based funcationaly (such as CDI) won't work for those classes, but this seems a corner case (and the solution is to build with the same version you are running).
quarkus-bot
bot
added
area/core
area/devtools
|
Does this fix a known issue? |
|
In some circumstances it can trigger a warning in the jacoco extension. |
|
Gotcha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't index classes that are not able to be
loaded as the current Java version is too low.
Note that if a newer JDK is used to run the
resulting application these classes will become
visible, however this is less likely to cause
problems than the current situation.
This is because adding invisible classes to the
index can result in bytecode being generated which
references these classes, which will cause startup
to fail. The alternative of not adding them to the
index only means that some annotation based funcationaly
(such as CDI) won't work for those classes, but
this seems a corner case (and the solution is to
build with the same version you are running).