Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added link of cache quickstart in cache.adoc #13769

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Added link of cache quickstart in cache.adoc #13769

merged 4 commits into from
Dec 9, 2020

Conversation

saumya1singh
Copy link
Contributor

@saumya1singh saumya1singh commented Dec 9, 2020 •
edited
Loading

Hey @loicmathieu !
PR for #12521
I have added the cache quickstart link in the guide.

@ghost ghost added the area/documentation label Dec 9, 2020
@loicmathieu
Copy link
Contributor

Thanks @SaumyaSingh1 if there is multiple guides with the same issue, maybe you can open a single PR with all the modification to avoid too much PR.

@saumya1singh
Copy link
Contributor Author

Thanks @SaumyaSingh1 if there is multiple guides with the same issue, maybe you can open a single PR with all the modification to avoid too much PR.

Yep sure I was thinking to do that only :P

@loicmathieu
Copy link
Contributor

OK, I'll approve this one then.

loicmathieu
loicmathieu approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saumya1singh
Copy link
Contributor Author

@loicmathieu So as of now I have added missing quickstarts in the guides.
I think the PR is ready to be merged .

@gastaldi gastaldi merged commit d5ee4b0 into quarkusio:master Dec 9, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 9, 2020
@gastaldi
Copy link
Contributor

gastaldi commented Dec 9, 2020

Thanks!

@saumya1singh saumya1singh deleted the ImprovingExtensionGuide branch December 9, 2020 16:27
@loicmathieu
Copy link
Contributor

Thanks, and congrats for your first PR (I think) ;)

@saumya1singh
Copy link
Contributor Author

Thank you so much @loicmathieu for the help 💙
Yes it was my first PR here :)

@gsmet gsmet modified the milestones: 1.11 - master, 1.10.4.Final Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.10.4.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saumya1singh @loicmathieu @gastaldi @gsmet