Skip to content

Remove spaces from quarkus.container-image.group when it's set to the username #13651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 3, 2020

Fixes: #13622

@@ -87,14 +87,15 @@
/**
* Since user.name which is default value can be uppercase and uppercase values are not allowed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-read this sentence and it is a bit confusing

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit c7b8698 into quarkusio:master Dec 3, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 3, 2020
@geoand geoand deleted the #13622 branch December 3, 2020 17:46
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.3.Final Dec 6, 2020
@gsmet gsmet modified the milestones: 1.10.3.Final, 1.7.6.Final Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Jib fails if username contains a space although it is not even used
3 participants