Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fault Tolerance metrics via Micrometer #12414

Merged
merged 1 commit into from Sep 30, 2020

Conversation

jmartisk
Copy link
Contributor

Fixes #12196

@Ladicek
Copy link
Contributor

Ladicek commented Sep 30, 2020

Is there a test somewhere that verifies the original issue is fixed? That's the only thing I can possibly say, since I don't understand anything metrics :-)

@jmartisk
Copy link
Contributor Author

AFAIK there are no tests for FT metrics working with SmallRye or with Micrometer right now.
Think we need to come up with a reasonable test suite architecture how to run tests for both, without too much code duplication. Almost reminds me of the times in Quality Engineering and the fun of testing matrices (test all combinations of everything with everything)!
This is definitely something we should think about, but I guess it's beyond this PR.

@kenfinnigan kenfinnigan added this to the 1.9.0 - master milestone Sep 30, 2020
@kenfinnigan kenfinnigan merged commit c9d2f54 into quarkusio:master Sep 30, 2020
@jmartisk jmartisk deleted the master-issue-12196 branch September 30, 2020 14:15
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.2.Final Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intersection of Smallrye, MP Metrics and micrometer not working
5 participants