Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the handling of the port 0 #12401

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix the handling of the port 0 #12401

merged 1 commit into from
Sep 29, 2020

Commits on Sep 29, 2020

  1. Fix the handling of the port 0 

    By updating the options object, it create a race conditions.
One verticle may be already listening and would have updated the port in the HTTP option.
So, the next verticle see this set port (no more 0) and try to bind on that port, which lead to a BindException.

This commit stores the actual HTTP and HTTPS port without modifying the HTTP options.
    @cescoffier
    cescoffier committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    70fa17d View commit details
    Browse the repository at this point in the history