Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use localhost for @TestHTTPResource #12370

Merged
merged 1 commit into from Sep 29, 2020
Merged

Always use localhost for @TestHTTPResource #12370

merged 1 commit into from Sep 29, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 28, 2020

Fixes: #12369

@geoand geoand marked this pull request as draft September 28, 2020 06:19
@stuartwdouglas
Copy link
Member

This will fail if they actually have bound to a different interface. Maybe just check for 0.0.0.0 as the host and replace it with localhost?

@geoand
Copy link
Contributor Author

geoand commented Sep 28, 2020

Right, that makes sense.

@geoand
Copy link
Contributor Author

geoand commented Sep 28, 2020

PR updated

@geoand geoand marked this pull request as ready for review September 29, 2020 05:11
@stuartwdouglas stuartwdouglas merged commit c9ab9fe into quarkusio:master Sep 29, 2020
@stuartwdouglas stuartwdouglas added this to the 1.9.0 - master milestone Sep 29, 2020
@geoand geoand deleted the #12369 branch September 29, 2020 12:45
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.2.Final Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.2.Final
Development

Successfully merging this pull request may close these issues.

TestHTTPResource does not return localhost
3 participants
@geoand @stuartwdouglas @gsmet