Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use neutral container image over docker image #11764

Merged
merged 1 commit into from Sep 1, 2020

Conversation

maxandersen
Copy link
Contributor

as raised on quarkus-dev its better to refer to container images
rather than docker image as it is not limited to docker container runtime.

@boring-cyborg boring-cyborg bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Sep 1, 2020
@gsmet
Copy link
Member

gsmet commented Sep 1, 2020

I think the main issue of the user was that we have docker commands in these files.

@geoand
Copy link
Contributor

geoand commented Sep 1, 2020

This is a good start however and in line with the terminology we use in the rest of the project (see container-image extensions)

@gsmet gsmet changed the title use neutral container image over docker image Use neutral container image over docker image Sep 1, 2020
@gsmet gsmet merged commit 4218fad into quarkusio:master Sep 1, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Sep 1, 2020
@maxandersen
Copy link
Contributor Author

I think the main issue of the user was that we have docker commands in these files.

yes, but that is harder to fix/test - as @geoand points out this is a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants