Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE at boot if a MetricsFactoryConsumerBuildItem contains null #11743

Merged
merged 1 commit into from Aug 31, 2020

Conversation

jmartisk
Copy link
Contributor

Fixes #11736

@jaikiran
Copy link
Member

Unrelated failure. It looks like we need to even @Disabled NativeMongodbPanacheResourceIT. I would have thought, extending a @Disabled ReactiveMongodbPanacheResourceTest would have prevented this one from being run. Apparently not.

2020-08-31T11:03:41.0574873Z 2020-08-31 11:03:41,029 INFO  [org.mon.dri.connection] (Thread-14) Opened connection [connectionId{localValue:13, serverValue:13}] to localhost:27018
2020-08-31T11:03:41.1270073Z [ERROR] Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 27.365 s <<< FAILURE! - in io.quarkus.it.mongodb.panache.reactive.NativeMongodbPanacheResourceIT
2020-08-31T11:03:41.1278278Z [ERROR] io.quarkus.it.mongodb.panache.reactive.NativeMongodbPanacheResourceIT.testReactiveBookEntity  Time elapsed: 14.181 s  <<< ERROR!
2020-08-31T11:03:41.1283511Z org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.it.mongodb.panache.reactive.ReactiveMongodbPanacheResourceTest that uses io.quarkus.it.mongodb.panache.reactive.ReactiveMongodbPanacheResourceTest$IntegerAdder was not fulfilled within 10 seconds.
2020-08-31T11:03:41.1283910Z 
2020-08-31T11:03:41.1286135Z [ERROR] io.quarkus.it.mongodb.panache.reactive.NativeMongodbPanacheResourceIT.testReactiveBookRepository  Time elapsed: 10.386 s  <<< ERROR!

@gsmet
Copy link
Member

gsmet commented Aug 31, 2020

@jaikiran @geoand has created a PR for it.

@geoand
Copy link
Contributor

geoand commented Aug 31, 2020

#11751

@gsmet gsmet merged commit e5b67d7 into quarkusio:master Aug 31, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants