Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide for jbang integration #11731

Merged
merged 1 commit into from Aug 30, 2020
Merged

Conversation

maxandersen
Copy link
Contributor

@maxandersen maxandersen commented Aug 30, 2020

follow up for #11542

this is a basic example based on the rest getting started guide but just done via jbang instead + showing the few gotchas/differences with current jbang (i.e. single source, Q:config vs application.properties, etc.)

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some typos, looks good

docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
@maxandersen
Copy link
Contributor Author

merged changes and squashed!

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxandersen maxandersen merged commit 8bb8213 into quarkusio:master Aug 30, 2020
@maxandersen maxandersen deleted the jbangdoc branch August 30, 2020 21:35
@gsmet gsmet added this to the 1.8.0.CR1 milestone Sep 2, 2020
@maxandersen maxandersen added the area/jbang Issues related to when using jbang.dev with Quarkus label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants