Add @SequenceGenerator to make Gift Entity example generally more usable

[svinther]

As described in this issue here: #11591

If blindly following the tutorial, it can cause weird sequence behavior in some cases. This pr aims to make the tutorial example usable in general

[gavinking]

I agree that this is much more correct. I believe that without the @SequenceGenerator annotation, this was illegal JPA code.

[gavinking]

I agree that this is much more correct. I believe that without the @SequenceGenerator annotation, this was illegal JPA code.

Except, I don't think you should specify @GeneratedValue(strategy=SEQUENCE) in this case. You don't need it. Just the name of the generator is enough.

[svinther]

I agree that this is much more correct. I believe that without the @SequenceGenerator annotation, this was illegal JPA code.

Except, I don't think you should specify @GeneratedValue(strategy=SEQUENCE) in this case. You don't need it. Just the name of the generator is enough.

I am fine with removing that part, but in this way it is in sync with the hibernate-orm quickstart https://github.com/quarkusio/quarkus-quickstarts/blob/master/hibernate-orm-quickstart/src/main/java/org/acme/hibernate/orm/Fruit.java#L20 ?

[gavinking]

Well I think it would be better to change both. We shouldn't give people the idea that they need to write code that is more verbose than necessary.

It's unfortunate that the Javadoc for the annotation actually has a code example with the same redundancy.

[svinther]

I have updated this PR, removing the verbose jpa annotations.

About the quickstarts, There are a few places where:

1. strategy=SEQUENCE is used along with generator=XX
2. strategy=AUTO (being the default value so can be omitted)

All of those can be removed as unnecessary verbosity, like this https://github.com/svinther/quarkus-quickstarts/commit/4231c1af9de754d4d30ba6d4157cdb95c24c84ba ?

[gastaldi]

Nice! May I ask you to squash your commits before qe merge this? Thank you!

[svinther]

@gastaldi commits squashed

[gastaldi]

Nice! Thank you!