Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle integration test dirs in PathTestHelper #11717

Merged
merged 1 commit into from Aug 31, 2020
Merged

Add gradle integration test dirs in PathTestHelper #11717

merged 1 commit into from Aug 31, 2020

Conversation

marraes
Copy link
Contributor

@marraes marraes commented Aug 28, 2020 •
edited

This workaround resolves #8950, to separate my unit tests from my integration test without get a error

@aloubyansky
Copy link
Member

@marraes could you please mvn clean package -pl test-framework/common and incorporate the changes? It'll properly format of the class. Thanks!

@aloubyansky aloubyansky added the area/gradle Gradle label Aug 28, 2020
@aloubyansky
Copy link
Member

And also please squash the commits. I should have asked for it before, sorry.

@gsmet
Copy link
Member

gsmet commented Aug 31, 2020

/cc @glefloch

glefloch
glefloch reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet added this to the 1.8.0 - master milestone Aug 31, 2020
@gsmet gsmet merged commit 9cae703 into quarkusio:master Aug 31, 2020
@marraes marraes deleted the feature/gradle-integration-tests-dir branch September 1, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glefloch glefloch glefloch left review comments

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/gradle Gradle area/testing
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus should be able to run tests in different folders than the "preset" ones
4 participants
@marraes @aloubyansky @gsmet @glefloch