-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Quartz Jobs through ArC #11507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a line or two in the Quartz documentation?
Other than that it LGTM too.
Thank you!
extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test/InjectJobTest.java
Show resolved
Hide resolved
Found a small bug while running the example in the docs. Let me double check before marking this PR for review |
Should be good now, sorry for the trouble 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the followup fixes!
@gastaldi @machi1990 I think that a better and more correct solution would be to inject |
Welcome back and thanks for the input / note @mkouba. Happy to review any followup PR if @gastaldi or anyone will be up for it :-) |
I can try to prepare a followup PR today... |
Thanks @mkouba |
Fixes #11496