Add a Micrometer extension #11073

ebullient · 2020-07-30T01:16:00Z

Introduce micrometer extension to provide support for micrometer metrics. Acts as an alternative to the smallrye metrics extension. Each extension provides a MetricsCapabilityBuildItem, which is a SimpleBuildItem; a project's build will fail with a message if both are enabled.

kenfinnigan

Overall it looks great, just a few minor comments

...icrometer/deployment/src/main/java/io/quarkus/micrometer/deployment/MicrometerProcessor.java

integration-tests/micrometer-jmx/pom.xml

integration-tests/micrometer-jmx/src/main/resources/application.properties

integration-tests/micrometer-mp-metrics/pom.xml

integration-tests/micrometer-mp-metrics/src/main/resources/application.properties

extensions/micrometer/runtime/src/main/resources/META-INF/quarkus-extension.yaml

kenfinnigan · 2020-08-20T12:54:06Z

docs/src/main/asciidoc/micrometer-metrics.adoc

+----
+
+This command generates a Maven project, that imports the `micrometer` extension and the micrometer
+prometheus registry as dependencies.


Does this add the prometheus registry dependency automatically? I thought it would just be the micrometer extension only and the prometheus registry needs to be manually added?

Not sure if you sure this comment @ebullient?

kenfinnigan · 2020-08-20T12:58:34Z

Other than the one comment on the guide, I think it's good from my side.

Next week we should move it out of draft status to have a chance of making 1.8 release

gsmet

I haven't looked at the code in detail but spotted a few issues.

Could you take care of them?

extensions/micrometer/runtime/pom.xml

extensions/micrometer/runtime/src/main/resources/META-INF/quarkus-extension.yaml

gsmet · 2020-08-27T11:11:52Z

CR1 will be released on September 2nd so if you plan to get this one, it needs to be merged by September 1st.

ebullient · 2020-08-27T21:30:02Z

Could you take care of them?

Building now. Thanks, @gsmet! =)

gsmet · 2020-08-27T22:07:06Z

It will also need a rebase.

ebullient · 2020-08-28T06:01:41Z

It will also need a rebase.

Naturally.

The documentation step failed with this:

2020-08-28T04:53:31.1411300Z [ERROR] Failed to execute goal on project quarkus-integration-test-mongodb-panache: Could not resolve dependencies for project io.quarkus:quarkus-integration-test-mongodb-panache:jar:999-SNAPSHOT: The following artifacts could not be resolved: io.quarkus:quarkus-micrometer:jar:999-SNAPSHOT, io.quarkus:quarkus-micrometer-deployment:pom:999-SNAPSHOT: Could not find artifact io.quarkus:quarkus-micrometer:jar:999-SNAPSHOT -> [Help 1]
2020-08-28T04:53:31.1411694Z [ERROR] 
2020-08-28T04:53:31.1412083Z [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
2020-08-28T04:53:31.1412453Z [ERROR] Re-run Maven using the -X switch to enable full debug logging.
2020-08-28T04:53:31.1412709Z [ERROR] 
2020-08-28T04:53:31.1412879Z [ERROR] For more information about the errors and possible solutions, please read the following articles:
2020-08-28T04:53:31.1413194Z [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
2020-08-28T04:53:31.1413444Z [ERROR] 
2020-08-28T04:53:31.1413602Z [ERROR] After correcting the problems, you can resume the build with the command
2020-08-28T04:53:31.1414018Z [ERROR]   mvn <args> -rf :quarkus-integration-test-mongodb-panache
2020-08-28T04:53:33.0350879Z ##[error]Process completed with exit code 1.

I am pretty sure the dependencies for the integration test are correct, but I wonder if the Documentation CI step is missing something?

gsmet · 2020-08-28T06:24:26Z

Question: is there any native tests? I don't see any addition of a module to ci-actions.yml so if there are any, they aren't run on CI.

ebullient · 2020-08-28T06:45:27Z

Question: is there any native tests? I don't see any addition of a module to ci-actions.yml so if there are any, they aren't run on CI.

Right. There are native tests (nothing fancy) that I was running in my own repo.. I forgot about the bucket definitions in ci-actions.yml. Should I add them to one of the existing categories? Make a new one?

gsmet · 2020-08-28T07:12:00Z

I would add them together with metrics and add a 5 minutes more to the timeout.

Also better rebase to get the latest CI fixes.

ebullient · 2020-08-28T14:16:00Z

I would add them together with metrics and add a 5 minutes more to the timeout.

Also better rebase to get the latest CI fixes.

Rebased. smallrye-metrics doesn't have dedicated integration tests (micrometer does to account for different backends). I added two of them to one of the misc buckets. Can change it if you want.

ebullient · 2020-08-29T01:39:24Z

There are two classloading problems in the non-micrometer-integration-tests running in native mode that were touched to use the micrometer extension instead of mp-metrics. I'm working on it.

gsmet · 2020-08-31T09:37:24Z

There are issues in the doc:

2020-08-31T03:11:25.2708106Z [INFO] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 173: table missing leading separator; recovering automatically
2020-08-31T03:11:25.2801064Z [INFO] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 228: table missing leading separator; recovering automatically
2020-08-31T03:11:25.3504994Z [INFO] Converted /home/runner/work/quarkus/quarkus/docs/src/main/asciidoc/micrometer-metrics.adoc
2020-08-31T03:11:25.3591888Z [ERROR] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 173: table missing leading separator; recovering automatically
2020-08-31T03:11:25.3603054Z [ERROR] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 228: table missing leading separator; recovering automatically

Please make a visual pass locally on the rendered output of the documentation when you're adding a significant piece of doc.

ebullient · 2020-08-31T13:13:38Z

There are issues in the doc:

2020-08-31T03:11:25.2708106Z [INFO] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 173: table missing leading separator; recovering automatically
2020-08-31T03:11:25.2801064Z [INFO] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 228: table missing leading separator; recovering automatically
2020-08-31T03:11:25.3504994Z [INFO] Converted /home/runner/work/quarkus/quarkus/docs/src/main/asciidoc/micrometer-metrics.adoc
2020-08-31T03:11:25.3591888Z [ERROR] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 173: table missing leading separator; recovering automatically
2020-08-31T03:11:25.3603054Z [ERROR] asciidoctor: ERROR: ed/config/quarkus-micrometer.adoc: line 228: table missing leading separator; recovering automatically

Please make a visual pass locally on the rendered output of the documentation when you're adding a significant piece of doc.

Yep. I saw that. I'm trying to sort that out. I have something locally (I needed to sleep ;) )

FWIW, I did check the docs in my other repo, but the behavior is a bit different when the contents are nested in a larger doc, and that's what is tripping it up (nested table). If I can't get it sorted, I'll ditch the table and go back to a list.

kenfinnigan

Minor comment on the doc related to what dependencies get added

kenfinnigan · 2020-08-31T14:15:53Z

docs/src/main/asciidoc/micrometer-metrics.adoc

+----
+
+This command generates a Maven project, that imports the `micrometer` extension and the micrometer
+prometheus registry as dependencies.


Not sure if you sure this comment @ebullient?

Enable MP Metrics if API is present by default

ebullient · 2020-08-31T22:10:44Z

All set, I think. =)

.github/workflows/ci-actions.yml

gsmet · 2020-09-01T11:08:33Z

OK, let's get this one merged. Thanks @ebullient !

boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/jaeger labels Jul 30, 2020

gsmet added this to the 1.8.0 milestone Jul 30, 2020

kenfinnigan reviewed Jul 31, 2020

View reviewed changes

ebullient mentioned this pull request Aug 3, 2020

Micrometer support in v1.8 #11180

Closed

ebullient mentioned this pull request Aug 13, 2020

micrometer quickstart quarkusio/quarkus-quickstarts#640

Merged

10 tasks

boring-cyborg bot added the area/documentation label Aug 13, 2020

kenfinnigan reviewed Aug 20, 2020

View reviewed changes

gsmet requested changes Aug 21, 2020

View reviewed changes

ebullient marked this pull request as ready for review August 28, 2020 05:52

boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Aug 28, 2020

ebullient changed the title ~~micrometer extension (draft / for 1.8)~~ micrometer extension Aug 28, 2020

boring-cyborg bot added area/core area/infinispan Infinispan area/jaxb area/kafka labels Aug 30, 2020

kenfinnigan approved these changes Aug 31, 2020

View reviewed changes

ebullient added 5 commits August 31, 2020 11:46

Micrometer extension

579aa76

Enable MP Metrics if API is present by default

hibernate-orm + micrometer

1d66915

jaeger + micrometer

7b08f35

mongodb + micrometer

3c8b3be

Micrometer guide

405a6f0

jmartisk reviewed Sep 1, 2020

View reviewed changes

.github/workflows/ci-actions.yml Show resolved Hide resolved

gsmet approved these changes Sep 1, 2020

View reviewed changes

gsmet merged commit 8980acd into quarkusio:master Sep 1, 2020

gsmet changed the title ~~micrometer extension~~ Add a Micrometer extension Sep 1, 2020

gsmet added the release/noteworthy-feature label Sep 1, 2020

ebullient deleted the micrometer branch September 17, 2020 23:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a Micrometer extension #11073

Add a Micrometer extension #11073

ebullient commented Jul 30, 2020

kenfinnigan left a comment

kenfinnigan Aug 20, 2020

kenfinnigan Aug 31, 2020

kenfinnigan commented Aug 20, 2020

gsmet left a comment

gsmet commented Aug 27, 2020

ebullient commented Aug 27, 2020

gsmet commented Aug 27, 2020

ebullient commented Aug 28, 2020

gsmet commented Aug 28, 2020

ebullient commented Aug 28, 2020

gsmet commented Aug 28, 2020

ebullient commented Aug 28, 2020

ebullient commented Aug 29, 2020

gsmet commented Aug 31, 2020

ebullient commented Aug 31, 2020 •

edited

kenfinnigan left a comment

kenfinnigan Aug 31, 2020

ebullient commented Aug 31, 2020

gsmet commented Sep 1, 2020

Add a Micrometer extension #11073

Add a Micrometer extension #11073

Conversation

ebullient commented Jul 30, 2020

kenfinnigan left a comment

Choose a reason for hiding this comment

kenfinnigan Aug 20, 2020

Choose a reason for hiding this comment

kenfinnigan Aug 31, 2020

Choose a reason for hiding this comment

kenfinnigan commented Aug 20, 2020

gsmet left a comment

Choose a reason for hiding this comment

gsmet commented Aug 27, 2020

ebullient commented Aug 27, 2020

gsmet commented Aug 27, 2020

ebullient commented Aug 28, 2020

gsmet commented Aug 28, 2020

ebullient commented Aug 28, 2020

gsmet commented Aug 28, 2020

ebullient commented Aug 28, 2020

ebullient commented Aug 29, 2020

gsmet commented Aug 31, 2020

ebullient commented Aug 31, 2020 • edited

kenfinnigan left a comment

Choose a reason for hiding this comment

kenfinnigan Aug 31, 2020

Choose a reason for hiding this comment

ebullient commented Aug 31, 2020

gsmet commented Sep 1, 2020

ebullient commented Aug 31, 2020 •

edited