-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RestEasy Reactive client: optional FormParameters throw error when null #23872
Labels
Milestone
Comments
/cc @FroMage, @geoand, @stuartwdouglas |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Feb 22, 2022
…ctive REST Client Fixes: quarkusio#23872
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Feb 22, 2022
…ctive REST Client Fixes: quarkusio#23872
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Feb 22, 2022
…ctive REST Client Fixes: quarkusio#23872
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Feb 22, 2022
…ctive REST Client Fixes: quarkusio#23872
geoand
added a commit
that referenced
this issue
Feb 22, 2022
Allow null values for query, cookies, headers and form params for Reactive REST Client
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Feb 28, 2022
…ctive REST Client Fixes: quarkusio#23872 (cherry picked from commit 5946440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using a reactive restclient created from an interface, it's not possible to call a method with an optional form parameter when the actual value of the parameter is null.
It gives the following error:
Expected behavior
The service method can be called without error and the value of the delivered parameter value is null.
Actual behavior
The error message from the bug description.
How to Reproduce?
Clone the following reproducer project:
https://github.com/pravussum/quarkus-restclient-reactive-formparam-repro
The test ReactiveGreetingResourceTest shows the good case (form param not null) and the error case (sent form param is null).
Output of
uname -a
orver
5.13.0-27-generic #29-Ubuntu SMP Wed Jan 12 17:36:47 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Output of
java -version
openjdk-15.0.2
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.7.1
Build tool (ie. output of
mvnw --version
orgradlew --version
)Maven 3.8.4
Additional information
The
JaxrsClientReactiveProcessor.addFormParam()
method does a "isString" check on the null value returned from the converter, which obviously fails and leads to the given error message.The null case should be handled properly here (neither throwing an exception, nor adding the parameter to the formParams map).
The text was updated successfully, but these errors were encountered: