Skip to content

Commit

Permalink
Merge pull request #25736 from glefloch/fix/25693
Browse files Browse the repository at this point in the history
Leverage Gradle build cache in integration tests
  • Loading branch information
geoand committed May 24, 2022
2 parents d2b4a72 + 58371c9 commit de381dc
Show file tree
Hide file tree
Showing 22 changed files with 46 additions and 41 deletions.
1 change: 1 addition & 0 deletions integration-tests/gradle/.gradle/gradle.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
org.gradle.caching=true
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void testRemoveNonExistentExtension() throws IOException, URISyntaxExcept
final File projectDir = getProjectDir("add-remove-extension-single-module-kts");

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "build");
assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();

final Path buildKts = projectDir.toPath().resolve("build.gradle.kts");
assertThat(buildKts).exists();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void testRemoveNonExistentExtension() throws IOException, URISyntaxExcept
final File projectDir = getProjectDir("add-remove-extension-single-module");

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "build");
assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();

final Path build = projectDir.toPath().resolve("build.gradle");
assertThat(build).exists();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package io.quarkus.gradle;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.assertj.core.api.Assertions.assertThat;

import java.io.File;
import java.io.IOException;
Expand All @@ -18,7 +18,6 @@ public class AdditionalSourceSetsTest extends QuarkusGradleWrapperTestBase {
public void executeFunctionalTest() throws URISyntaxException, IOException, InterruptedException {
final File projectDir = getProjectDir("additional-source-sets");
BuildResult result = runGradleWrapper(projectDir, "functionalTest");
assertEquals(BuildResult.SUCCESS_OUTCOME, result.getTasks().get(":functionalTest"),
"Failed to run tests defined in an alternate test sources directory");
assertThat(BuildResult.isSuccessful(result.getTasks().get(":functionalTest"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ public void shouldRunTestCorrectly() throws Exception {

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "test");

assertThat(buildResult.getTasks().get(":application:test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":application:test"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void shouldRunTestCorrectly() throws Exception {

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "test");

assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();
}

@Test
Expand All @@ -24,7 +24,7 @@ public void shouldContainsPanacheMarkerFile() throws Exception {

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "quarkusBuild");

assertThat(buildResult.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":quarkusBuild"))).isTrue();
File buildDir = new File(projectDir, "build");

Path metaInfDir = buildDir.toPath().resolve("classes").resolve("java").resolve("main").resolve("META-INF");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public void shouldSuccessfullyInjectApplicationConfigInTest() throws Exception {

BuildResult testResult = runGradleWrapper(projectDir, "clean", ":application:test");

assertThat(testResult.getTasks().get(":application:test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(testResult.getTasks().get(":application:test"))).isTrue();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ public class BeanInTestSourcesTest extends QuarkusGradleWrapperTestBase {
public void testBasicMultiModuleBuild() throws Exception {
final File projectDir = getProjectDir("bean-in-testsources-project");
final BuildResult build = runGradleWrapper(projectDir, "clean", "test");
assertThat(build.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":test"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class BuildResult {

public static final String SUCCESS_OUTCOME = "SUCCESS";
public static final String UPTODATE_OUTCOME = "UP-TO-DATE";
public static final String FROM_CACHE = "FROM-CACHE";
private static final String TASK_RESULT_PREFIX = "> Task";

private Map<String, String> tasks;
Expand Down Expand Up @@ -54,4 +55,8 @@ public Map<String, String> getTasks() {
public String getOutput() {
return output;
}

public static boolean isSuccessful(String result) {
return SUCCESS_OUTCOME.equals(result) || FROM_CACHE.equals(result);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ public void test() throws Exception {
final File projectDir = getProjectDir("custom-filesystem-provider");

BuildResult build = runGradleWrapper(projectDir, "clean", ":application:test");
assertThat(build.getTasks().get(":application:test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":application:test"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void shoudBuildProjectWithDependencyConstraint() throws Exception {

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "quarkusBuild", "-Dquarkus.package.type=mutable-jar");

assertThat(buildResult.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":quarkusBuild"))).isTrue();

final File buildDir = new File(projectDir, "build");
final Path mainLib = buildDir.toPath().resolve("quarkus-app").resolve("lib").resolve("main");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ public void shouldResolveDependencyVersionFromSuperConfigurationProject()

final BuildResult result = runGradleWrapper(projectDir, "clean", "quarkusBuild");

assertThat(result.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(result.getTasks().get(":quarkusBuild"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ public void testBasicMultiModuleBuild() throws Exception {
final File projectDir = getProjectDir("inject-bean-from-test-config");

BuildResult build = runGradleWrapper(projectDir, "clean", ":application:test");
assertThat(build.getTasks().get(":application:test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":application:test"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ public void shouldRunIntegrationTestAsPartOfBuild() throws Exception {

BuildResult buildResult = runGradleWrapper(projectDir, "clean", "quarkusIntTest");

assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(buildResult.getTasks().get(":quarkusIntTest")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":quarkusIntTest"))).isTrue();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ public void testBasicMultiModuleBuild() throws Exception {
final File projectDir = getProjectDir("jandex-basic-multi-module-project");

BuildResult build = runGradleWrapper(projectDir, "clean", ":application:quarkusBuild");
assertThat(build.getTasks().get(":common:jandex")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(build.getTasks().get(":application:quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":common:jandex"))).isTrue();
assertThat(BuildResult.isSuccessful(build.getTasks().get(":application:quarkusBuild"))).isTrue();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class KotlinGRPCProjectBuildTest extends QuarkusGradleWrapperTestBase {
public void testBasicMultiModuleBuild() throws Exception {
final File projectDir = getProjectDir("kotlin-grpc-project");
final BuildResult build = runGradleWrapper(projectDir, "clean", "build");
assertThat(build.getTasks().get(":quarkusGenerateCode")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(build.getTasks().get(":compileKotlin")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":quarkusGenerateCode"))).isTrue();
assertThat(BuildResult.isSuccessful(build.getTasks().get(":compileKotlin"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class MultiModuleKotlinProjectBuildTest extends QuarkusGradleWrapperTestB
public void testBasicMultiModuleBuild() throws Exception {
final File projectDir = getProjectDir("multi-module-kotlin-project");
final BuildResult build = runGradleWrapper(projectDir, "clean", "build");
assertThat(build.getTasks().get(":quarkusGenerateCode")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(build.getTasks().get(":compileKotlin")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":quarkusGenerateCode"))).isTrue();
assertThat(BuildResult.isSuccessful(build.getTasks().get(":compileKotlin"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public void shouldRunTest() throws Exception {
final File projectDir = getProjectDir("multi-source-project");
final BuildResult buildResult = runGradleWrapper(projectDir, ":clean", ":test");

assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void canBuild(SourceType sourceType) throws Exception {

BuildResult build = runGradleWrapper(projectRoot, "build", "--stacktrace");

assertThat(build.getTasks().get(":build")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(build.getTasks().get(":build"))).isTrue();
// gradle build should not build the native image
assertThat(build.getTasks().get(":buildNative")).isNull();
Path buildDir = projectRoot.toPath().resolve("build");
Expand All @@ -51,7 +51,7 @@ public void canDetectUpToDateBuild() throws Exception {
createProject(SourceType.JAVA);

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();

BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.UPTODATE_OUTCOME);
Expand All @@ -62,40 +62,40 @@ public void canDetectResourceChangeWhenBuilding() throws Exception {
createProject(SourceType.JAVA);

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();

final File applicationProperties = projectRoot.toPath().resolve("src/main/resources/application.properties").toFile();
Files.write(applicationProperties.toPath(), "quarkus.http.port=8888".getBytes());

BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(secondBuild.getTasks().get(":quarkusBuild"))).isTrue();
}

@Test
public void canDetectClassChangeWhenBuilding() throws Exception {
createProject(SourceType.JAVA);

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();

final File greetingResourceFile = projectRoot.toPath().resolve("src/main/java/org/acme/foo/GreetingResource.java")
.toFile();
DevModeTestUtils.filter(greetingResourceFile, ImmutableMap.of("\"/greeting\"", "\"/test/hello\""));

BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(secondBuild.getTasks().get(":quarkusBuild"))).isTrue();
}

@Test
public void canDetectClasspathChangeWhenBuilding() throws Exception {
createProject(SourceType.JAVA);

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();

runGradleWrapper(projectRoot, "addExtension", "--extensions=hibernate-orm");
BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");
assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(secondBuild.getTasks().get(":quarkusBuild"))).isTrue();
}

@Test
Expand All @@ -104,13 +104,13 @@ public void canDetectOutputChangeWhenBuilding() throws Exception {

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");

assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();
Path runnerJar = projectRoot.toPath().resolve("build").resolve("quarkus-app").resolve("quarkus-run.jar");
Files.delete(runnerJar);

BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");

assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(secondBuild.getTasks().get(":quarkusBuild"))).isTrue();
assertThat(runnerJar).exists();
}

Expand All @@ -120,7 +120,7 @@ public void canDetectUpToDateTests() throws Exception {

BuildResult firstBuild = runGradleWrapper(projectRoot, "test");

assertThat(firstBuild.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":test"))).isTrue();

BuildResult secondBuild = runGradleWrapper(projectRoot, "test");

Expand All @@ -133,12 +133,12 @@ public void canDetectSystemPropertyChangeWhenBuilding() throws Exception {

BuildResult firstBuild = runGradleWrapper(projectRoot, "quarkusBuild", "--stacktrace");

assertThat(firstBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":quarkusBuild"))).isTrue();
assertThat(projectRoot.toPath().resolve("build").resolve("quarkus-app").resolve("quarkus-run.jar")).exists();

BuildResult secondBuild = runGradleWrapper(projectRoot, "quarkusBuild", "-Dquarkus.package.type=fast-jar");

assertThat(secondBuild.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(secondBuild.getTasks().get(":quarkusBuild"))).isTrue();
assertThat(projectRoot.toPath().resolve("build").resolve("quarkus-app")).exists();
}

Expand All @@ -148,7 +148,7 @@ public void canRunTest() throws Exception {

BuildResult buildResult = runGradleWrapper(projectRoot, "test", "--stacktrace");

assertThat(buildResult.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(buildResult.getTasks().get(":test"))).isTrue();
}

@Test
Expand All @@ -158,7 +158,7 @@ public void generateCodeBeforeTests() throws Exception {
BuildResult firstBuild = runGradleWrapper(projectRoot, "test", "--stacktrace");
assertThat(firstBuild.getOutput()).contains("Task :quarkusGenerateCode");
assertThat(firstBuild.getOutput()).contains("Task :quarkusGenerateCodeTests");
assertThat(firstBuild.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(firstBuild.getTasks().get(":test"))).isTrue();
}

private void createProject(SourceType sourceType) throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ public void testQuarkusBuildShouldWorkWithSpringDependencyManagement()

final BuildResult result = runGradleWrapper(projectDir, "clean", "quarkusBuild");

assertThat(result.getTasks().get(":quarkusBuild")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(result.getTasks().get(":quarkusBuild"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ public void testTaskShouldUseTestFixtures() throws IOException, URISyntaxExcepti

final BuildResult result = runGradleWrapper(projectDir, "clean", "test");

assertThat(result.getTasks().get(":test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(result.getTasks().get(":test"))).isTrue();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ public class TestFixtureMultiModuleTest extends QuarkusGradleWrapperTestBase {
public void testTaskShouldUseTestFixtures() throws IOException, URISyntaxException, InterruptedException {
final File projectDir = getProjectDir("test-fixtures-multi-module");
final BuildResult result = runGradleWrapper(projectDir, "clean", "test");
assertThat(result.getTasks().get(":application:test")).isEqualTo(BuildResult.SUCCESS_OUTCOME);
assertThat(BuildResult.isSuccessful(result.getTasks().get(":application:test"))).isTrue();
}
}

0 comments on commit de381dc

Please sign in to comment.