Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Load to Quarkus App #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

karesti
Copy link
Member

@karesti karesti commented Mar 7, 2024

I have done in this PR:

  • Convert to a Quarkus App
  • Use Picocli. In reality a simple Quarkus main would be enough if the app remains this simple
  • Change the code to use RestClient instead of custom rest api calls
  • There aren't 3 threads, but 3 sequential calls randomly executed

Things to discuss here:

  • I'm unable to stop the java class and I tried to find a proper way with picocli and I was unable to find one.
  • RestClient methods should be "Uni" "Multi" for reactive ?
  • Do we want to enhance this picocli application with more options ? Or should we simply have a Quarkus Main

Closes #100

@karesti
Copy link
Member Author

karesti commented Mar 7, 2024

@agoncal @holly-cummins questions here

@karesti karesti force-pushed the picocli-app branch 8 times, most recently from 13c3ef1 to 64c53a7 Compare March 8, 2024 10:33
@karesti karesti marked this pull request as ready for review June 6, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn Load Super Heroes into a Quarkus + PicoCLI app
1 participant