Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a checkport.java to check open necessary ports #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxandersen
Copy link

idea i got when having to manually run lsof.

this is a script portable on all OS and runs using plain java (jbang instructions just there for ./checkports.java exec)

@github-actions
Copy link

🚀 PR Preview debbb99 has been successfully built and deployed to https://quarkiverse-quarkus-workshops-pr-349-preview.surge.sh

@agoncal
Copy link
Collaborator

agoncal commented Sep 28, 2023

Really nice

@agoncal
Copy link
Collaborator

agoncal commented Oct 9, 2023

@maxandersen what about merging the PR and documenting the usage of this utility class ?

@holly-cummins
Copy link
Collaborator

holly-cummins commented Oct 9, 2023

I put a comment somewhere, but I've misplaced it, because don't see it here ... I like this script a lot, but I'm not sure the workshop is the right place for it. My preference in the workshop is that we stick to first principles, and teaching people to fish rather than giving them scripts that fish for them.

If we teach workshop participants how lsof can solve their problems in general, they're really getting something out of the workshop. @maxandersen pointed out that lsof doesn't work on windows, so we'd need a guard and a netstat command, but that's easy to do. To me, that's more educational than the checkports script ... but I think we should find somewhere for the checkports script where it can be used by a bigger audience, like in the quarkus cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants