Add jbangcatalog and make qrcode more resilient #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why:
* its tedious to write:
`jbang https://github.com/quarkusio/quarkus-workshops/blob/main/quarkus-workshop-super-heroes/docs/src/resource-generation/qrcode.java https://shattereddisk.github.io/rickroll/ mycode.png`
* would much rather just do:
`jbang qrcode@quarkusio/quarkus-workshops https://shattereddisk.github.io/rickroll` and have the filename be optional.
or simply
`jbang qrcode https://shattereddisk.github.io/rickroll mycode.png` anywhere within the repo.
This change addreses the need by:
* add `jbang-catalog.json` to the repo
made using `jbang alias add -f . quarkus-workshop-super-heroes/docs/src/resource-generation/qrcode.java`
* made `qrcode.java` default the file name to avoid having to specify it and to avoid exception thrown.
|
I like the change to qrcode.java, but I'm slightly unsure about putting jbang catalog content into the top level of the repo, since the repo's main purpose is as a sample application to teach Quarkus. The QR code generation is only used as part of the CI, here, and we probably want to keep it isolated from the user-visible parts of the repo. I wonder, if we think there's likely to be re-use of the script, if it should be re-homed and catalog-ed somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
jbang https://github.com/quarkusio/quarkus-workshops/blob/main/quarkus-workshop-super-heroes/docs/src/resource-generation/qrcode.java https://shattereddisk.github.io/rickroll/ mycode.pngjbang qrcode@quarkusio/quarkus-workshops https://shattereddisk.github.io/rickrolland have the filename be optional. or simplyjbang qrcode https://shattereddisk.github.io/rickroll mycode.pnganywhere within the repo.This change addreses the need by:
jbang-catalog.jsonto the repo made usingjbang alias add -f . quarkus-workshop-super-heroes/docs/src/resource-generation/qrcode.javaqrcode.javadefault the file name to avoid having to specify it and to avoid exception thrown.