Simple test for case where organisation is missing from a payload #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
holly-skeleton-push-projects-test
branch
from
aab4c94
to
e445fdf
Compare
|
This is now ready for review, since we have included a new version of quarkus-github-app. |
gsmet
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test case to go along with #257, except I was too slow to catch the fix before it merged :)
This fix depends on quarkiverse/quarkus-github-app#343, and then us pulling in a new version of GitHub app, so I will leave it in draft for a while so we're not tempted to merge it too early.
Ideally the
PushToProjectsTestwould be a bit more comprehensive, but this is a start that we can build on. I didn't have a payload with an organisation handy, or an issue payload, so I couldn't add the deeper tests without some effort.