Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[class-creator]: Add loan pattern to incapsulate life cycle of ClassCreator inside API #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

poldinik
Copy link

…ass creator inside API

[This feature allows to hide life cycle of class creator from user prospective using a loan pattern]
@dmlloyd
Copy link
Member

dmlloyd commented Apr 2, 2024

I like the idea of this change (note that a few of the APIs I have added to this project in the past also use this pattern, and the new JDK classfile API does as well). But IMO we should apply it more uniformly, as opposed to haphazardly applying it to different places with no real overall plan.

@poldinik
Copy link
Author

poldinik commented Apr 6, 2024

I like the idea of this change (note that a few of the APIs I have added to this project in the past also use this pattern, and the new JDK classfile API does as well). But IMO we should apply it more uniformly, as opposed to haphazardly applying it to different places with no real overall plan.

How we can lead ahead this feature more systematically? Which step you see I need to follow to propose it and contribute? I mean something like roadmap o design specification before actual develop and avoid waste of time if stakeholders don't like implementation

@dmlloyd
Copy link
Member

dmlloyd commented Apr 22, 2024

This is a good question that I do not have an answer to. Maybe start with a high-level proposal that encompasses the existing API usages for method, class, and block creators, and go from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants