Support tests of classes which use DynamicGraphQLClient

[holly-cummins]

As part of my (second, unpushed) fix for quarkusio/quarkus-github-bot#257, I tried to add a test for a PushToProjects, a class which has the following method signature:

    void pullRequestLabeled(@PullRequest.Labeled GHEventPayload.PullRequest pullRequestPayload,
            @ConfigFile("quarkus-github-bot.yml") QuarkusGitHubBotConfigFile quarkusBotConfigFile,
            GitHub gitHub, DynamicGraphQLClient gitHubGraphQLClient) throws IOException {

That test fails with the following exception

[ERROR] io.quarkus.bot.it.PushToProjectsTest.triageComment  Time elapsed: 0.495 s  <<< FAILURE!
java.lang.AssertionError: The event handler threw an exception: The GraphQL client has not been initialized and should not be accessed.
        at io.quarkiverse.githubapp.testing.internal.EventSenderOptionsImpl.event(EventSenderOptionsImpl.java:111)
        at io.quarkiverse.githubapp.testing.internal.EventSenderOptionsImpl.event(EventSenderOptionsImpl.java:85)
        at io.quarkiverse.githubapp.testing.internal.EventSenderOptionsImpl.event(EventSenderOptionsImpl.java:20)
        at io.quarkus.bot.it.PushToProjectsTest.triageComment(PushToProjectsTest.java:73)
...
Caused by: java.lang.IllegalStateException: The GraphQL client has not been initialized and should not be accessed.
        at io.quarkiverse.githubapp.runtime.MultiplexedEvent.getGitHubGraphQLClient(MultiplexedEvent.java:41)
        at io.quarkus.bot.PushToProjects_Multiplexer.pullRequestLabeled_35c5add42697742b520a6db1fd7be53b4ad45669(Unknown Source)
        at io.quarkus.bot.PushToProjects_Multiplexer_Observer_pullRequestLabeled_35c5add42697742b520a6db1fd7be53b4ad45669_b65c7b03e7d0ca92e5b8d9ccb80a1a828633ab4f.notify(Unknown Source)
        at io.quarkus.arc.impl.EventImpl$Notifier.notifyObservers(EventImpl.java:323)
        at io.quarkus.arc.impl.EventImpl$Notifier.notify(EventImpl.java:305)
        at io.quarkus.arc.impl.EventImpl$1.get(EventImpl.java:103)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
        at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:555)

I couldn't figure out a good workaround at the test level, but updating the mocking support to also mock getInstallationGraphQLClient on GitHubService allows the test to proceed.

I've done a simple mock, on the basis that once the hook is there dependencies can add behaviour if they need it.

[gsmet]

Yeah I somehow gave up on this as I was pretty sure I wouldn’t be patient enough to write the GraphQL mocks :)

Let’s see what @yrodiere who wrote this infrastructure think of it!

[holly-cummins]

I have to admit that I'm not planning to write any GraphQL mocks either, just some light testing of other aspects of a class that references GraphQL. :)
(Famous last words - first you do some light testing of a class that knows about GraphQL, and the next thing you know you've entirely duplicated GraphQL in the medium of mocks.)

[yrodiere]

I've done a simple mock, on the basis that once the hook is there dependencies can add behaviour if they need it.

Makes sense, in this case DynamicGraphQLClient is an interface (hurray!) and does not have any getter that may return another mock, so we don't need all the hacks we have for the GitHub client.

No idea how easy it will be to actually mock the client, but I agree one should be allowed to try, at least :)

Let’s see what @yrodiere who wrote this infrastructure think of it!

Looks good to me.

We might want to make it easier by allowing to point to a resource file representing the mocked response, but that can be done as a second step... if someone wants it badly enough to do it :)

Merging, thanks!

[gsmet]

@allcontributors add @holly-cummins for code

[allcontributors]

@gsmet

I've put up a pull request to add @holly-cummins! 🎉