Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bincode file implementation #1350

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Bincode file implementation #1350

wants to merge 17 commits into from

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented May 13, 2024

  • change file format from JSON to binary (via Rust's bincode)

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 20, 2024 0:37am

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 79.31770% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 89.14%. Comparing base (b624d04) to head (e9cddcb).
Report is 56 commits behind head on main.

Files Patch % Lines
quadratic-core/src/grid/file/v1_5/file.rs 74.73% 71 Missing ⚠️
quadratic-core/src/grid/file/v1_6/file.rs 72.22% 15 Missing ⚠️
quadratic-core/src/grid/file/v1_6/schema.rs 66.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
- Coverage   89.24%   89.14%   -0.11%     
==========================================
  Files         160      162       +2     
  Lines       26318    26656     +338     
==========================================
+ Hits        23488    23762     +274     
- Misses       2830     2894      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1350 May 17, 2024 19:10 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1350 May 17, 2024 19:11 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1350 May 18, 2024 14:21 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1350 May 20, 2024 12:01 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1350 May 20, 2024 12:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants