Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiline ai assist prompts #1346

Merged
merged 9 commits into from
May 21, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

closes #1210

Changes:

  • Added Textarea component which can auto grow unto a max height, used this for AI assist promts. Max height is currently set to 120px, configurable via props.
  • Fixed auto focus of prompt input on selecting AI assistant tab.
ai.assist.prompt.input.webm

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

vercel bot commented May 11, 2024

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 20, 2024 7:04pm

Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few additional fixes, tweaks to this, including:

  • CMD+Enter submits the textarea, with Enter and Shift+Enter now inserting a line. This aligns the input more broadly with web app textarea inputs (like twitter) as well as our own code editor which uses CMD+Enter to "submit" and run the code while Enter just adds a new line. Added a shortcut to the tooltip to indicate this to the user

CleanShot 2024-05-21 at 10 10 44@2x

  • Multi-line user inputs were not displaying as multi-line messages from the user who typed them. Now they do.

CleanShot 2024-05-21 at 10 00 23@2x

  • "Send" button aligns to the bottom of the textarea as it expands in height (so does loading indicator)

CleanShot 2024-05-21 at 09 43 52@2x

@jimniels
Copy link
Collaborator

Will merge this once all tests pass...

@jimniels jimniels merged commit eb54932 into quadratichq:main May 21, 2024
8 of 11 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/1210 branch May 21, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: multiline ai assistant prompts
3 participants