Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prettytable-rs to 0.10.0 #193

Merged
merged 1 commit into from Aug 5, 2023
Merged

Conversation

ichyo
Copy link
Contributor

@ichyo ichyo commented Jun 11, 2023

I've seen segmentation faults from cargo equip and it seems that's caused by one of dependencies prettytable-rs

Program received signal SIGSEGV, Segmentation fault.
0x00005555559d9c50 in prettytable::TableSlice::get_all_column_width ()
(gdb) where
#0  0x00005555559d9c50 in prettytable::TableSlice::get_all_column_width ()
#1  0x00005555559da3af in <prettytable::TableSlice as core::fmt::Display>::fmt ()
#2  0x00005555555ec7a2 in cargo_equip::bundle::list_packages ()
#3  0x00005555555e905b in cargo_equip::bundle ()
#4  0x00005555555e470e in cargo_equip::run ()
#5  0x00005555555c019f in cargo_equip::main ()

Since this was fixed in 0.10.0 (phsym/prettytable-rs#146), I'd like to get the library upgraded to the version.

@qryxip
Copy link
Owner

qryxip commented Aug 5, 2023

Thank you for PR! Merging.

@qryxip qryxip merged commit a6fb6a7 into qryxip:master Aug 5, 2023
5 of 8 checks passed
@qryxip
Copy link
Owner

qryxip commented Aug 6, 2023

Released v0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segmentation fault: cargo equip --exclude-atcoder-crates --resolve-cfgs --remove docs --minify
2 participants