Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1402][IMP]change-color-negative-website_sale_available_qty #290

Merged
merged 3 commits into from Nov 4, 2020
Merged

[1402][IMP]change-color-negative-website_sale_available_qty #290

merged 3 commits into from Nov 4, 2020

Conversation

Ryoko04
Copy link
Member

@Ryoko04 Ryoko04 commented Nov 2, 2020

Task 1402

@codecov-io
Copy link

Codecov Report

Merging #290 into st1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              st1     #290   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         167      167           
  Lines        5715     5715           
=======================================
  Hits         3143     3143           
  Misses       2572     2572

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167fff...80db400. Read the comment docs.

@TimLai125
Copy link

There seems to be some issue with pre-commit installation on the prettier package, there are some suggestions from here: prettier/prettier#9459
I guess we might wait until https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/pre-commit-13.0/.pre-commit-config.yaml is updated.

TimLai125
TimLai125 approved these changes Nov 2, 2020
View reviewed changes
Copy link

@TimLai125 TimLai125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TimLai125 TimLai125 force-pushed the 1402-change-color-negative-website_sale_available_qty branch from b69674d to a6c4437 Compare November 4, 2020 07:07
@TimLai125 TimLai125 marked this pull request as ready for review November 4, 2020 08:40
@TimLai125 TimLai125 merged commit c3e6d4c into st1 Nov 4, 2020
@TimLai125 TimLai125 deleted the 1402-change-color-negative-website_sale_available_qty branch November 4, 2020 09:09
TimLai125 pushed a commit that referenced this pull request Nov 5, 2020
@Ryoko04
[1402][IMP]change-color-negative-website_sale_available_qty (#290)
f7d2d88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimLai125 TimLai125 TimLai125 approved these changes

Assignees
No one assigned
Labels
merged into 11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ryoko04 @codecov-io @TimLai125