Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Main-Class' header to slf4j-migrator Manifest.MF #334

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

HannesWell
Copy link
Contributor

@HannesWell HannesWell commented Jan 12, 2023

Because the Manifest.MF did not have a terminating new-line it was invalid and its content was ignored.

Disable the execution of the 'maven-bundle-plugin' for the migrator module to not have (useless) OSGi-metadata generated into it.

@HannesWell HannesWell force-pushed the migrator_mainClass branch 2 times, most recently from 5745320 to dc3e630 Compare January 12, 2023 22:39
@HannesWell HannesWell force-pushed the migrator_mainClass branch 2 times, most recently from 3c87ebc to 3d574d5 Compare March 18, 2023 16:35
@HannesWell
Copy link
Contributor Author

@ceki maybe do you want to have a look at this as well. Because of this the migration can probably not used as described here:
https://www.slf4j.org/migrator.html

Alternatively this entry could be generated using the maven-jar-plugin, but since the intention is to use the maven-bundle-plugin in all other plugins to generate Manifest-entries (#340) I choose to use it here as well.

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-jar-plugin</artifactId>
        <configuration>
          <archive>
            <manifest>
              <mainClass>org.slf4j.migrator.Main</mainClass>
            </manifest>
          </archive>
        </configuration>
      </plugin>

Because the Manifest.MF did not have a terminating new-line it was
invalid and its content was ignored, thus the Main-Class entry was
missing.

To have less files in the project, generate the entry using the
maven-bundle-plugin.

Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
@ceki ceki merged commit f871e7f into qos-ch:master Apr 9, 2023
10 checks passed
@HannesWell HannesWell deleted the migrator_mainClass branch April 10, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants