SLF4J-447: Move org.slf4j.NDC from slf4j-ext to slf4j-api #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfl4j-api owns the org.slf4j package (automatic Java module); slf4j-ext must not have any classes in the org.slf4j package. Note that the NDCTest stays in slf4j-ext. The test cannot be moved to slf4j-api because slf4j-api includes a stub StaticMDCBinder instead of a real one resulting the test failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfl4j-api owns the org.slf4j package (automatic Java module);
slf4j-ext must not have any classes in the org.slf4j package.
Note that the NDCTest stays in slf4j-ext.
The test cannot be moved to slf4j-api because slf4j-api includes
a stub StaticMDCBinder instead of a real one resulting the test
failing.
https://jira.qos.ch/browse/SLF4J-447
I think it would be really nice to get this change into a 1.7.x release.