use MessageFormat insetad of String.format to comply spec of System.L…

…ogger.log Signed-off-by: Taku Miyakawa <miyakawa.taku@gmail.com>
qos-ch · Aug 8, 2023 · 0769bc8 · 0769bc8
1 parent e63f87f
commit 0769bc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...dk-platform-logging/src/main/java/org/slf4j/jdk/platform/logging/SLF4JPlatformLogger.java b/...dk-platform-logging/src/main/java/org/slf4j/jdk/platform/logging/SLF4JPlatformLogger.java
@@ -26,6 +26,7 @@
 
 import static java.util.Objects.requireNonNull;
 
+import java.text.MessageFormat;
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
 
@@ -142,7 +143,7 @@ private void performLog(org.slf4j.event.Level slf4jLevel, ResourceBundle bundle,
                 leb = leb.addArgument(p);
             }
             // The JDK uses a different formatting convention. We must invoke it now.
-            message = String.format(message, params);
+            message = MessageFormat.format(message, params);
         }
         if (leb instanceof CallerBoundaryAware) {
             CallerBoundaryAware cba = (CallerBoundaryAware) leb;

diff --git a/...m-logging/src/test/java/org/slf4j/jdk/platform/logging/test/SLF4JPlatformLoggingTest.java b/...m-logging/src/test/java/org/slf4j/jdk/platform/logging/test/SLF4JPlatformLoggingTest.java
@@ -88,7 +88,7 @@ public void smoke() throws IOException {
         assertEquals(EXPECTED_FINDER_CLASS, finder.getClass().getName());
         Logger systemLogger = finder.getLogger("smoke", null);
         systemLogger.log(Level.INFO, "hello");
-        systemLogger.log(Level.INFO, "hello %s", "world");
+        systemLogger.log(Level.INFO, "hello {0}", "world");
 
         List<String> results = SPS.stringList;
         assertEquals(2, results.size());