Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #803 PatternLayoutBase custom converter classloading in OSGi #804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enapps-enorman
Copy link

This is the proposed changes to resolve issue #803

This is an alternate way to declare the PatternLayoutBase defaultConverterMap and instanceConverterMap values in a way that works with the OSGi classloading restrictions.

These changes should preserve backward compatibility with code that defines the converter map using the original technique

I also updated the tests in an attempt to confirm it works as expected.

Please review and merge if you agree with the proposed changes.

Signed-off-by: Eric Norman <enorman@apache.org>
@enapps-enorman enapps-enorman force-pushed the issue/patternlayout_convertermap_classloading branch from 0c60720 to f510980 Compare April 16, 2024 21:51
@enapps-enorman
Copy link
Author

Hi @ceki

We would appreciate a review of this proposal if you (or someone else) has the time. Knowing if this proposal will be accepted or not will help us decide how to move forward.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant