Feature to clean up logs by last modified date for TimeBasedArchiveRemover #763
+121
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancishen
force-pushed
the
cleanup-using-last-modified-date
branch
from
ed5b7a5
to
1583084
Compare
…rchiveRemover Signed-off-by: Tianci Shen <shentianci2042@gmail.com>
tiancishen
force-pushed
the
cleanup-using-last-modified-date
branch
from
1583084
to
a88e7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#764
Added a new flag cleanLogsByLastModifiedDate to
TimeBasedArchiveRemover, to enable cleaning log files by when they were last modified instead of looping through the expected file names.Added missing checkIncrement field to SizeAndTimeBasedRollingPolicy and pass to SizeAndTimeBasedFNATP