Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Fixes errors for missing file URLs for spring configuration locations #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jgibson
Copy link

@jgibson jgibson commented Feb 16, 2016

This fixes issue #39. I had to tweak the build a bit to get it to accept a different name on the copyright header, if there's a better approach to that then let me know.

@jgibson
Copy link
Author

jgibson commented Apr 13, 2016

These tests are just ensuring that the WebLogbackConfigurer doesn't throw an exception when provided with missing URLs and instead falls back to the default logging configuration.

I guess that we can stick an assertTrue() at the end of these to show that the test was successful. A stronger test would be to ensure that the default logging initialization occurred, but I don't know how to do that. Even if we could do the test it would be fragile if a developer specified their own logging configuration via a system property or a configuration file.

@jgibson
Copy link
Author

jgibson commented Oct 29, 2016

OK, after a little thought and poking at Spring's MockServletContext I realized that it wasn't too difficult to test out the error messages for missing configurations. A user who has specified their own logging configuration may still break the test, but it's less likely now.

@tony19
Copy link
Contributor

tony19 commented Feb 8, 2018

I tried rebasing this onto master, but it did not compile (symbol not found, bad @Override, etc.). Can you please rebase? See wip/pr40.

tony19 added a commit that referenced this pull request Feb 8, 2018
@jgibson
Copy link
Author

jgibson commented Feb 9, 2018

I'd totally forgotten about this one. Anyways, sure, I'll take a look by next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants