Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix grammar #309

wants to merge 1 commit into from
+2 −2

Conversation

maul-a
Copy link

@maul-a maul-a commented Mar 14, 2024

Start generate -> start generating

@maul-a
Copy link
Author

maul-a commented Apr 9, 2024

@qmhc

qmhc
qmhc reviewed Apr 12, 2024
View reviewed changes
src/plugin.ts
@@ -636,7 +636,7 @@ export function dtsPlugin(options: PluginOptions = {}): import('vite').Plugin {
bundleDebug('insert index')

if (rollupTypes) {
logger.info(green(`${logPrefix} Start rollup declaration files...`))
logger.info(green(`${logPrefix} Start generating rollup declaration files...`))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here it's better to use 'rolling up'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmhc qmhc qmhc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maul-a @qmhc