fix: include .d.ts extension in multiple outputs #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmhc
approved these changes
Jan 8, 2023
|
Can confirm this happens with multiple entry files. A workaround currently is to use the dts({
insertTypesEntry: true,
beforeWriteFile(filePath) {
return { filePath: filePath.endsWith('.d.ts') ? filePath : `${filePath}.d.ts` }
},
}), |
This was
linked to
issues
Jan 30, 2023
qmhc
requested changes
Jan 30, 2023
| @@ -438,7 +438,7 @@ export function dtsPlugin(options: PluginOptions = {}): import('vite').Plugin { | |||
| const typesPath = types ? resolve(root, types) : resolve(outputDir, indexName) | |||
|
|
|||
| for (const name of entryNames) { | |||
| let filePath = multiple ? resolve(outputDir, name.replace(tsRE, '.d.ts')) : typesPath | |||
| let filePath = multiple ? resolve(outputDir, `${name}.d.ts`) : typesPath | |||
There was a problem hiding this comment.
We should judge whether the extension is included here, because it will fail when extension exists (xxx.ts -> xxx.ts.d.ts).
There was a problem hiding this comment.
And we should apply the same change to line 491.
There was a problem hiding this comment.
Makes sense 👍
Also, I'm no longer using your library and don't have time to contribute anymore. Feel free to pick up this PR where I left off.
There was a problem hiding this comment.
All right, thanks for your contributions, I will fix it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this comment #136 (comment)
Perhaps it also fixes this issue #144
Problem
With multiple entries,
nameequals the name of the input, which doesn't include any file extension. Therefore, thetsReregex doesn't work.Fix
Add
.d.tsextension manually to these entries