Skip to content

Commit

Permalink
Fix tox errors
Browse files Browse the repository at this point in the history
1. Ignore base python conflict error

New version of tox (4.2.4?) fails if there is mismatch in spec
attributes [1]. We can change the base python to match with the test
envs, but it may make it inconvenient to setup local development env,
so just ignore the error to workaround the issue.

2. Allow running bash in bandit test

[1] tox-dev/tox#2824
  • Loading branch information
qixiang committed Mar 9, 2023
1 parent f5ad1c2 commit 090e2c8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tox.ini
Expand Up @@ -5,6 +5,7 @@

[tox]
envlist = bandit, docs, flake8, mypy, py310
ignore_base_python_conflict = True

[testenv]
basepython = python3
Expand Down Expand Up @@ -39,6 +40,7 @@ commands =
basepython = python3
skip_install = true
deps = bandit
allowlist_externals = /bin/bash
commands =
; 0.0.0.0 is set in BaseConfiguration, which is ok for local dev and it
; will be replace with a specific host IP when deploy to a server. So, it
Expand Down

0 comments on commit 090e2c8

Please sign in to comment.