Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Yahoo Finance tutorial with popular companies #211

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Update Yahoo Finance tutorial with popular companies #211

merged 1 commit into from
Oct 6, 2022

Conversation

manoelmarques
Copy link
Contributor

@manoelmarques manoelmarques commented Oct 5, 2022 •
edited

Summary

Latest yfinance release introduced a possible bug where key error exceptions were raised for unknown tickers.
Issue created: ranaroussi/yfinance#1076

Also, updated yahoo tutorial to use popular companies.

Details and comments

@manoelmarques manoelmarques added type: bug Something isn't working priority: high labels Oct 5, 2022
@manoelmarques manoelmarques self-assigned this Oct 5, 2022
@manoelmarques manoelmarques changed the title Pin yfinance due to bug in latest release Pin yfinance due to possible bug in latest release Oct 5, 2022
@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Oct 5, 2022
@coveralls
Copy link

coveralls commented Oct 6, 2022 •
edited

Pull Request Test Coverage Report for Build 3198290143

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.708%
Totals Coverage Status
Change from base Build 3129515852: 0.0%
Covered Lines: 642
Relevant Lines: 848
💛 - Coveralls

woodsp-ibm
woodsp-ibm previously approved these changes Oct 6, 2022
View reviewed changes
@manoelmarques manoelmarques marked this pull request as draft October 6, 2022 13:15
@manoelmarques manoelmarques added the on hold Can not fix yet label Oct 6, 2022
@manoelmarques manoelmarques changed the title Pin yfinance due to possible bug in latest release Update Yahoo Finance tutorial with known companies Oct 6, 2022
@manoelmarques manoelmarques removed the on hold Can not fix yet label Oct 6, 2022
@manoelmarques manoelmarques marked this pull request as ready for review October 6, 2022 14:43
@manoelmarques manoelmarques changed the title Update Yahoo Finance tutorial with known companies Update Yahoo Finance tutorial with well known companies Oct 6, 2022
@manoelmarques manoelmarques changed the title Update Yahoo Finance tutorial with well known companies Update Yahoo Finance tutorial with popular companies Oct 6, 2022
@manoelmarques manoelmarques merged commit e7ff2dd into qiskit-community:main Oct 6, 2022
@manoelmarques manoelmarques deleted the pin branch October 6, 2022 17:26
mergify bot pushed a commit that referenced this pull request Oct 6, 2022
@manoelmarques @mergify
Update Yahoo Finance tutorial with popular companies (#211)
24c2615 
(cherry picked from commit e7ff2dd)
@mergify mergify bot mentioned this pull request Oct 6, 2022
Merged
manoelmarques added a commit that referenced this pull request Oct 6, 2022
@mergify @manoelmarques
Update Yahoo Finance tutorial with popular companies (#211) (#212)
85688c0 
(cherry picked from commit e7ff2dd)

Co-authored-by: Manoel Marques <manoelmrqs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

Assignees

@manoelmarques manoelmarques

Labels
priority: high stable backport potential The bug might be minimal and/or import enough to be port to stable type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manoelmarques @coveralls @woodsp-ibm