Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull mdal 1.2.0 from upstream #57492

Merged
merged 1 commit into from
May 23, 2024
Merged

pull mdal 1.2.0 from upstream #57492

merged 1 commit into from
May 23, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented May 20, 2024

Description

Update internal mdal version to 1.2.0

https://github.com/lutraconsulting/MDAL/releases/tag/release-1.2.0

@github-actions github-actions bot added this to the 3.38.0 milestone May 20, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 2e6cde2)

@nyalldawson
Copy link
Collaborator

Is the clang warning here a false positive?

@uclaros
Copy link
Contributor Author

uclaros commented May 22, 2024

Is the clang warning here a false positive?

I believe yes, it doesn't like subtracting '0' from an integer in nodeType == w_id - '0'. I could change that to w_id - 48 and add a comment that 48 is ascii 0, but wouldn't do an mdal release for that!

@nyalldawson nyalldawson merged commit 1896419 into qgis:master May 23, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants