[Processing] Fix Dissolve alg for featureless input layer or containing empty/null geometries, when the output is a memory layer (Fix #53392) #57478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agiudiceandrea
changed the title
agiudiceandrea
added
Processing
agiudiceandrea
commented
May 18, 2024
| @@ -36,10 +36,16 @@ QVariantMap QgsCollectorAlgorithm::processCollection( const QVariantMap ¶met | |||
| if ( !sink ) | |||
| throw QgsProcessingException( invalidSinkError( parameters, QStringLiteral( "OUTPUT" ) ) ); | |||
|
|
|||
| QVariantMap outputs; | |||
| outputs.insert( QStringLiteral( "OUTPUT" ), dest ); | |||
|
|
|||
| const QStringList fields = parameterAsStrings( parameters, QStringLiteral( "FIELD" ), context ); | |||
|
|
|||
| const long count = source->featureCount(); | |||
There was a problem hiding this comment.
Not related to this PR, but... shouldn't this be long long instead of long?
There was a problem hiding this comment.
Yes, it should be long long everywhere
There was a problem hiding this comment.
Since it looks like there are many processing algorithms with the same issue, I will subsequently propose a PR to fix them all together.
nyalldawson
approved these changes
May 18, 2024
nyalldawson
added
backport queued_ltr_backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the "Dissolve" (
native:dissolve) processing algorithm which fails to execute when the output layer is a memory layer (particularly when the algorithm is used as part of a model) and the input layer doesn't contain any features or contains features with empty/null geometry as detailed in #53392.This proposed fix makes sure the Dissolve algorithm:
Fixes #53392.