Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying Center Loss #213

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Applying Center Loss #213

merged 5 commits into from
Dec 29, 2023

Conversation

parthkl021
Copy link
Contributor

This commit fixes the issue #187
Center Loss as defined in the paper "A Discriminative Feature Learning Approach for Deep Face Recognition (http://ydwen.github.io/papers/WenECCV16.pdf) It aims to minimize the intra-class variations while keeping the features of different classes separable.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for capable-unicorn-d5e336 ready!

Name Link
🔨 Latest commit c0a0761
🔍 Latest deploy log https://app.netlify.com/sites/capable-unicorn-d5e336/deploys/658ec0912887e40008a2a6ec
😎 Deploy Preview https://deploy-preview-213--capable-unicorn-d5e336.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@parthkl021
Copy link
Contributor Author

I am new to open source and this organization, can anyone give me an idea as for what are these issues and how should I solve them

@generall
Copy link
Member

It failed because of documentation generation failed:

6:56:39 PM: /opt/buildhome/python3.8/lib/python3.8/site-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: "libc10_cuda.so: cannot open shared object file: No such file or directory"If you don"t plan on using image functionality from `torchvision.io`, you can ignore this warning. Otherwise, there might be something wrong with your environment. Did you have `libjpeg` or `libpng` installed before building `torchvision` from source?
  warn(
6:56:39 PM: /opt/build/repo/docs/source/api/index.rst:122: WARNING: autosummary: failed to import fastap_loss.FastAPLoss.
6:56:39 PM: Possible hints:
6:56:39 PM: * KeyError: "fastap_loss"
6:56:39 PM: * AttributeError: module "quaterion.loss" has no attribute "fastap_loss"
6:56:39 PM: * ModuleNotFoundError: No module named "quaterion.loss.fastap_loss"
6:56:39 PM: * ModuleNotFoundError: No module named "fastap_loss"
6:56:39 PM: /opt/build/repo/docs/source/getting_started/quick_start.rst:2: WARNING: Duplicate explicit target name: "tutorial".
6:56:39 PM: /opt/build/repo/docs/source/getting_started/quick_start.rst:2: WARNING: Duplicate explicit target name: "tutorial".
6:56:39 PM: /opt/build/repo/docs/source/getting_started/quick_start.rst:2: WARNING: Duplicate explicit target name: "tutorial".
6:56:39 PM: /opt/build/repo/docs/source/getting_started/quick_start.rst:2: WARNING: Duplicate explicit target name: "tutorial".
6:56:39 PM: /opt/buildhome/python3.8/lib/python3.8/site-packages/quaterion/loss/cos_face_loss.py:docstring of quaterion.loss.cos_face_loss.CosFaceLoss.forward:3: ERROR: Unexpected indentation.
6:56:39 PM: /opt/buildhome/python3.8/lib/python3.8/site-packages/quaterion/loss/cos_face_loss.py:docstring of quaterion.loss.cos_face_loss.CosFaceLoss.forward:4: WARNING: Block quote ends without a blank line; unexpected unindent.
6:56:39 PM: /opt/build/repo/docs/source/tutorials/triplet_loss_trick.rst:2: WARNING: Title underline too short.
6:56:39 PM: Triplet Loss: Vector Collapse Prevention
6:56:39 PM: ============================
6:56:39 PM: looking for now-outdated files... none found
6:56:39 PM: pickling environment... done
6:56:39 PM: checking consistency... done
6:56:39 PM: preparing documents... WARNING: unsupported theme option "social_preview" given
6:56:39 PM: done
6:56:39 PM: copying assets... copying static files... done
6:56:39 PM: copying extra files... done
6:56:39 PM: done
6:56:39 PM: writing output... [  1%] api/index
6:56:39 PM: Theme error:
6:56:39 PM: An error happened in rendering the page api/index.
6:56:39 PM: Reason: UndefinedError(""style" is undefined")
6:56:40 PM: ​
6:56:40 PM: "build.command" failed                                        
6:56:40 PM: ────────────────────────────────────────────────────────────────
6:56:40 PM: ​
6:56:40 PM:   Error message
6:56:40 PM:   Command failed with exit code 2: bash -x docs/generate_docs_netlify.sh (https://ntl.fyi/exit-code-2)
6:56:40 PM: ​
6:56:40 PM:   Error location
6:56:40 PM:   In build.command from netlify.toml:
6:56:40 PM:   bash -x docs/generate_docs_netlify.sh
6:56:40 PM: ​
6:56:40 PM:   Resolved config
6:56:40 PM:   build:
6:56:40 PM:     command: bash -x docs/generate_docs_netlify.sh
6:56:40 PM:     commandOrigin: config
6:56:40 PM:     environment:
6:56:40 PM:       - PYTHON_VERSION
6:56:40 PM:       - REVIEW_ID
6:56:40 PM:     publish: /opt/build/repo/docs/html
6:56:40 PM:     publishOrigin: config
6:56:41 PM: Failed during stage "building site": Build script returned non-zero exit code: 2
6:56:41 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
6:56:41 PM: Failing build: Failed to build site
6:56:41 PM: Finished processing build request in 1m27.987s

@generall
Copy link
Member

You can try to run locally bash -x docs/generate_docs_netlify.sh

@parthkl021
Copy link
Contributor Author

The errors mentioned here are not of the files I made changes into, were they pre-existing or am I getting it wrong.
I just looked into the code its fast_ap_loss (in quaterion\loss__init__.py ) instead of fastap_loss as mentioned here

@parthkl021
Copy link
Contributor Author

@generall I have added the changes

@generall generall merged commit db4f455 into qdrant:master Dec 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants