Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd depts and insure compatibility #201

Merged
merged 20 commits into from
Mar 29, 2023
Merged

Upd depts and insure compatibility #201

merged 20 commits into from
Mar 29, 2023

Conversation

monatis
Copy link
Contributor

@monatis monatis commented Mar 28, 2023

  • Updated depts. Workflows were broken after Pytorch 2.0 while installing the pinned 1.12.1.
  • Added small compatibility code for pytorch-lightnin 1.9.0.
  • Updated version to 0.1.35 to make a release with recently merged CircleLoss and FastAPLoss.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for capable-unicorn-d5e336 ready!

Name Link
🔨 Latest commit 6e628b1
🔍 Latest deploy log https://app.netlify.com/sites/capable-unicorn-d5e336/deploys/6423b8fb0dc57800071781ff
😎 Deploy Preview https://deploy-preview-201--capable-unicorn-d5e336.netlify.app/_modules/quaterion/train/callbacks/cleanup_callback
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@monatis monatis requested a review from joein March 28, 2023 19:35
@monatis monatis changed the title [WIP] Fix workflows Upd depts and insure compatibility Mar 28, 2023
Co-authored-by: George <george.panchuk@qdrant.tech>
@monatis monatis requested a review from joein March 29, 2023 04:08
@@ -31,7 +31,7 @@ ipdb = "^0.13.9"
sphinx = ">=5.0.1"
qdrant-sphinx-theme = { git = "https://github.com/qdrant/qdrant_sphinx_theme.git", branch = "master" }
black = "^22.3.0"
torchvision = "^0.12.0"
torchvision = ">=0.12.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fixing torchvision to 0.12.x (latest = 0.15.x) and the latest poetry couldn't verify its hash on CI, essentially braking our tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, my bad, I forgot that ^x.y.z does not allow to increase y if x == 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joein joein self-requested a review March 29, 2023 08:20
@monatis monatis merged commit 1745697 into master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants