Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jaccard Distance #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zzzz-vincent
Copy link

add weighted Jaccard Distance as additional distance metrics.
add new test cases for it

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for capable-unicorn-d5e336 ready!

Name Link
🔨 Latest commit 230511b
🔍 Latest deploy log https://app.netlify.com/sites/capable-unicorn-d5e336/deploys/6401afacb89ff40008f17ab6
😎 Deploy Preview https://deploy-preview-196--capable-unicorn-d5e336.netlify.app/_modules/quaterion/distances
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@monatis
Copy link
Contributor

monatis commented Mar 3, 2023

I'm not sure that we should include it in Quaterion as I'm not familiar with any use of the weighted Jaccard distance in deep metric learning. What is your motivation to include it?

@zzzz-vincent
Copy link
Author

Hi monatia, I was working on adding Jaccard Distance to qdrant. So I was thinking it might also be helpful to have it in quaterion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants