Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Black version in Pre-commit hooks #100

Merged
merged 2 commits into from May 26, 2021
Merged

Update Black version in Pre-commit hooks #100

merged 2 commits into from May 26, 2021

Conversation

lazyoracle
Copy link
Member

What

Update black version in pre-commit hooks

Why

Fix for psf/black#1629 included in version 21.4b0 and above

How

Bump black version in .pre-commit-config.yaml

Note on updating your workflows

Once this PR is merged, please perform the following steps to make sure your commit hooks and workflows use the latest black version:

stash your WIP changes in the current working branch

git stash push -m "WIP on <branch-name> <short status>"

pull latest dev to get updated pre-commit hooks

  • git checkout dev
  • git pull upstream dev assuming you are working in a forked repo
  • pip install --upgrade pip
  • pip install --upgrade pre-commit

merge, install and use updated hooks on your WIP branch

  • git checkout <branch-name>
  • git merge dev
  • pre-commit install
  • git stash pop
  • git add <files>
  • git commit -m <message>

At this point, pre-commit hook should automatically update its dependencies to reflect your updated config file. This will usually take a few minutes.

@lazyoracle lazyoracle added bug Something isn't working code-quality General code quality related issues and PRs dependencies Pull requests that update a dependency file labels May 26, 2021
@lazyoracle lazyoracle self-assigned this May 26, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #100 (6a0b13b) into dev (8369d14) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #100   +/-   ##
=======================================
  Coverage   51.48%   51.48%           
=======================================
  Files          36       36           
  Lines        5409     5409           
=======================================
  Hits         2785     2785           
  Misses       2624     2624           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8369d14...6a0b13b. Read the comment docs.

@lazyoracle lazyoracle merged commit 969941d into dev May 26, 2021
@lazyoracle lazyoracle deleted the black-fix branch May 26, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code-quality General code quality related issues and PRs dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant