Skip to content

Commit

Permalink
Update re: feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
pzuraq committed Feb 2, 2024
1 parent 9cdd8a8 commit e72bf2a
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions spec.html
Original file line number Diff line number Diff line change
Expand Up @@ -6881,26 +6881,26 @@ <h1>
<emu-alg>
1. Let _privateMethods_ be a new empty List.
1. For each element _element_ of _elementDefinitions_, do
1. If _element_.[[Key]] is a Private Name and _element_.[[Kind]] is ~method~, ~getter~, ~setter~, or ~accessor~, then
1. If _element_.[[Key]] is a Private Name and _element_.[[Kind]] is one of ~method~, ~getter~, ~setter~, or ~accessor~, then
1. If _element_.[[Kind]] is ~method~, then
1. Let _privateElement_ be PrivateElement { [[Key]]: _element_.[[Key]], [[Kind]]: ~method~, [[Value]]: _element_.[[Value]] }.
1. Append _privateElement_ to _privateMethods_.
1. Else if _element_.[[Kind]] is ~accessor~, then
1. Let _privateElement_ be PrivateElement { [[Key]]: _element_.[[Key]], [[Kind]]: ~accessor~, [[Get]]: _element_.[[Get]], [[Set]]: _element_.[[Set]] }.
1. Append _privateElement_ to _privateMethods_.
1. Else,
1. Assert: _element_.[[Kind]] is ~getter~ or ~setter~.
1. Assert: _element_.[[Kind]] is either ~getter~ or ~setter~.
1. If _element_.[[Kind]] is ~getter~, let _getter_ be _element_.[[Get]].
1. Else, let _getter_ be *undefined*.
1. If _element_.[[Kind]] is ~setter~, let _setter_ be _element_.[[Set]].
1. Else, let _setter_ be *undefined*.
1. Let _existing_ be *undefined*.
1. If _privateMethods_ contains a PrivateElement _e_ such that _existing_.[[Key]] is _e_.[[Key]], then
1. If _privateMethods_ contains a PrivateElement _e_ such that _e_.[[Key]] is _element_.[[Key]], then
1. Assert: _e_.[[Kind]] is ~accessor~.
1. Set _existing_ to _e_.
1. If _e_.[[Get]] is not *undefined*, set _getter_ to _existing_.[[Get]].
1. If _e_.[[Set]] is not *undefined*, set _setter_ to _existing_.[[Set]].
1. Let _privateElement_ be PrivateElement { [[Key]]: _element_.[[Key]], [[Kind]]: ~accessor~, [[Get]]: getter, [[Set]]: setter }.
1. Let _privateElement_ be PrivateElement { [[Key]]: _element_.[[Key]], [[Kind]]: ~accessor~, [[Get]]: _getter_, [[Set]]: _setter_ }.
1. If _existing_ is not *undefined*, replace _existing_ in _privateMethods_ with _privateElement_.
1. Else, append _privateElement_ to _privateMethods_.
1. For each element _method_ of _privateMethods_, do
Expand Down Expand Up @@ -13805,13 +13805,15 @@ <h1>
</dl>
<emu-alg>
1. Assert: _homeObject_ is an ordinary, extensible object with no non-configurable properties.
1. Assert: _methodDefinition_.[[Kind]] is ~method~, ~getter~, ~setter~, or ~accessor~.
1. Assert: _methodDefinition_.[[Kind]] is one of ~method~, ~getter~, ~setter~, or ~accessor~.
1. Let _key_ be _methodDefinition_.[[Key]].
1. If _key_ is not a Private Name, then
1. Let _desc_ be the PropertyDescriptor { [[Enumerable]]: _enumerable_, [[Configurable]]: *true* }.
1. If _methodDefinition_.[[Kind]] is ~getter~ or ~accessor~, set _desc_.[[Get]] to _methodDefinition_.[[Get]].
1. If _methodDefinition_.[[Kind]] is ~setter~ or ~accessor~, set _desc_.[[Set]] to _methodDefinition_.[[Set]].
1. If _methodDefinition_.[[Kind]] is ~method~, set _desc_.[[Value]] to _methodDefinition_.[[Value]] and _desc_.[[Writable]] to *true*.
1. If _methodDefinition_.[[Kind]] is either ~getter~ or ~accessor~, set _desc_.[[Get]] to _methodDefinition_.[[Get]].
1. If _methodDefinition_.[[Kind]] is either ~setter~ or ~accessor~, set _desc_.[[Set]] to _methodDefinition_.[[Set]].
1. If _methodDefinition_.[[Kind]] is ~method~, then
1. Set _desc_.[[Value]] to _methodDefinition_.[[Value]].
1. Set _desc_.[[Writable]] to *true*.
1. Perform ? DefinePropertyOrThrow(_homeObject_, _key_, _desc_).
1. Return ~unused~.
</emu-alg>
Expand Down Expand Up @@ -24756,7 +24758,7 @@ <h1>
1. If IsCallable(_initializer_) is *true*, prepend _initializer_ to _elementRecord_.[[Initializers]].
1. Else if _initializer_ is not *undefined*, throw a *TypeError* exception.
1. Else if _newValue_ is not *undefined*, then
1. throw a *TypeError* exception.
1. Throw a *TypeError* exception.
1. Else,
1. If IsCallable(_newValue_) is *true*, then
1. If _kind_ is ~getter~, then
Expand All @@ -24766,7 +24768,7 @@ <h1>
1. Else,
1. Set _elementRecord_.[[Value]] to _newValue_.
1. Else if _newValue_ is not *undefined*, then
1. throw a *TypeError* exception.
1. Throw a *TypeError* exception.
1. Set _elementRecord_.[[Decorators]] to ~empty~.
1. Return ~unused~.
</emu-alg>
Expand Down Expand Up @@ -25399,7 +25401,7 @@ <h1>
<emu-alg>
1. Let _name_ be ? Evaluation of |ClassElementName|.
1. If _name_ is a Private Name, let _readableName_ be _name_.[[Description]].
1. Else if _name_ is a Symbol, let _readableName_ be SymbolDescriptiveString(_name).
1. Else if _name_ is a Symbol, let _readableName_ be SymbolDescriptiveString(_name_).
1. Else, let _readableName_ be _name_.
1. Let _privateStateDesc_ be the string-concatenation of _readableName_ and *" accessor storage"*.
1. Let _privateStateName_ be a new Private Name whose [[Description]] is _privateStateDesc_.
Expand Down

0 comments on commit e72bf2a

Please sign in to comment.