Fixes #1706: 0.14: Pinned Sphinx to below 2.0.0 also for py3.5+ #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-sphinx
branch
from
837e40a
to
50cc10b
Compare
andy-maier
force-pushed
the
andy/fix-sphinx
branch
from
50cc10b
to
4aa0c59
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/fix-sphinx
branch
from
4aa0c59
to
318b786
Compare
Details: - Sphinx 2.0.0 requires Python >=3.5, so the Sphinx requirement in dev-requirements.txt now limits Sphinx to <2.0.0 for Python <3.5. - Sphinx 2.0.0 fails (e.g. Python 3.7) with an AttributeError in the Napoleon extension. Issue sphinx-doc/sphinx#6246 has been opened. This change mitigates that failure by pinning Sphinx to <2.0.0 also for Python >=3.5. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/fix-sphinx
branch
from
318b786
to
d851816
Compare
|
The issue in Sphinx is supposedly fixed by sphinx-doc/sphinx#6237 and should be released soon as a fix release for 2.0. When that happens, our requirements file can be changed to just exclude the one failing version 2.0.0. |
KSchopmeyer
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.