Checks for type checks that do not raise TypeError #6002
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pyvista-bot LGTM |
pyvista-bot
previously approved these changes
Apr 30, 2024
tkoyama010
commented
May 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 140 140
Lines 24376 24376
=======================================
Hits 23626 23626
Misses 750 750 |
|
@pyvista-bot LGTM |
pyvista-bot
previously approved these changes
May 1, 2024
auto-merge was automatically disabled
May 1, 2024 01:02
Pull request was converted to draft
tkoyama010
commented
May 1, 2024
dcbr
reviewed
May 2, 2024
| self._name = color_names.get(self.hex_rgb, None) | ||
| except ValueError as e: | ||
| except TypeError as e: |
There was a problem hiding this comment.
Suggested change
| except TypeError as e: | |
| except (ValueError, TypeError) as e: |
The _from_rgba and _from_str methods can still raise a ValueError. I haven't checked the other changes here, but be careful there as well when changing the exception type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checks for type checks that do not raise TypeError.
Details