Update contour_labeled filter
#5968
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 141 141
Lines 24666 24718 +52
=======================================
+ Hits 23925 23976 +51
- Misses 741 742 +1 |
|
@pyvista-bot preview |
|
@pyvista-bot preview |
|
@pyvista-bot preview |
|
@pyvista-bot preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add new params and update a few existing ones for the
contour_labeledfilter.Some of these features are used directly by #5966.
Details
selectedoutput style and associatedselect_outputsparam to filter output labelsselect_inputsparam to filter input labels before contouringsmoothing_constraint_distance, it currently has no effect since automatic smoothing constraints are on by default which override this value (This is fixed by settingalg.AutomaticSmoothingConstraintsOff())smoothing_constraint_scaleto allow setting a relative smoothing constraint distanceoutput_mesh_type. The default forvtkSurfaceNetsis to use quads when smoothing is off, and triangles when smoothing is on. I think this dynamic default makes sense instead of forcingquadsto be the default since the quads are likely non-planar for smoothed meshes.