Move google_analytics_id to analytics in pydata-sphinx-theme #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
tkoyama010
changed the title
tkoyama010
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 83 83
Lines 18560 18560
=======================================
Hits 17654 17654
Misses 906 906 |
akaszynski
reviewed
Nov 21, 2022
akaszynski
reviewed
Nov 21, 2022
|
Let's add our key using the existing dictionary format. |
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
banesullivan
approved these changes
Nov 22, 2022
adeak
added a commit
to adeak/pyvista
that referenced
this pull request
Nov 25, 2022
* upstream/main: Python 3 style using pyupgrade (pyvista#3638) Move google_analytics_id to analytics in pydata-sphinx-theme (pyvista#3634)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
google_analytics_idis deprecated in pydata-sphinx-theme after 0.12. Useanalyticsinstead.#3611
Details